Skip to content

Packaging: Update to 1.0#466

Merged
alecbcs merged 23 commits into
mainfrom
v1_packaging_updates
Aug 6, 2025
Merged

Packaging: Update to 1.0#466
alecbcs merged 23 commits into
mainfrom
v1_packaging_updates

Conversation

@tldahlgren

@tldahlgren tldahlgren commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

This PR brings the Package Creation Tutorial up to v1.0.

@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch 2 times, most recently from 9ee0522 to bb89a05 Compare August 4, 2025 18:03
@tldahlgren tldahlgren changed the title [WIP] Packaging: Update to 1.0 Packaging: Update to 1.0 Aug 5, 2025
@tldahlgren tldahlgren marked this pull request as ready for review August 5, 2025 01:55
@alecbcs

alecbcs commented Aug 5, 2025

Copy link
Copy Markdown
Member

To test this out we should rebase on main and also add packaging.sh back into outputs/Makefile.

tldahlgren added 10 commits August 5, 2025 08:49
@tldahlgren
Packaging: Update to 1.0
afdf48a 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Snapshot of additional changes
17a58a2 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Packaging: add VISUAL as alternative to EDITOR based on implementation
d2d0528 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Add links to intorduction and creation lists (since good jumping off …
4688542 
…points)

Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Add a transition from contents review to the highlighted package
9b1211e 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Add links to checksum verification and command
caec23b 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Replace 'mpileaks' with 'tutorial-mpileaks' where should have been
92f64fc 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Completed first pass
50fe794 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
HOPEFULLY the package changes stick this time
266c059 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren
Another pass with tweaks and link corrections
24491a6 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from 7dce079 to 24491a6 Compare August 5, 2025 17:04
@tldahlgren

tldahlgren commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

To test this out we should rebase on main and also add packaging.sh back into outputs/Makefile.

It appears in run-scripting and local with dependency on stacks. Does that mean that should wait until the stacks tutorial issues are resolved?

@tldahlgren

tldahlgren commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

The changes in are for the basics and environments sections. Those shouldn't be affected by this PR.

Should the commit be dropped since a rebase should pick up the proper updates?

@tldahlgren tldahlgren requested a review from alecbcs August 5, 2025 17:32
@tldahlgren
Add 'spack repo list' to tutorial repo set up process
8beebcd 
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from 2ac9f05 to 8beebcd Compare August 5, 2025 17:46
@tldahlgren

tldahlgren commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

The changes in are for the basics and environments sections. Those shouldn't be affected by this PR.

Should the commit be dropped since a rebase should pick up the proper updates?

🤔 Forgot to pull before adding 'spack repo list' commit.

@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from 4a3c19f to e50bdb2 Compare August 5, 2025 22:23
@tldahlgren
Add repo configuration
5693e4f 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren
Add missing package from 'spack info' command; Autotools->AutotoolsBu…
439c868 
…ilder

Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren
Update repo config
2e116ce 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from d322ce7 to 2e116ce Compare August 5, 2025 23:33
@tldahlgren
Fix highlighted lines
c014d8e 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from 6b6f095 to c014d8e Compare August 6, 2025 00:24
@tldahlgren
Fix package repo's tip reference
fa00b9d 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren
Add the cleanup again
56d9c2a 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren

tldahlgren commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

To test this out we should rebase on main and also add packaging.sh back into outputs/Makefile.

It appears in run-scripting and local with dependency on stacks. Does that mean that should wait until the stacks tutorial issues are resolved?

@alecbcs @becker33 I still haven't enabled packaging.sh since it appears to rely on stacks.sh, which is disabled. Should I have enabled it?

@tldahlgren
rename local repository directory
1348447 
Signed-off-by: tldahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren tldahlgren force-pushed the v1_packaging_updates branch from eb37184 to 1348447 Compare August 6, 2025 01:21
@alecbcs

alecbcs commented Aug 6, 2025

Copy link
Copy Markdown
Member

Packaging depends on stacks only because that's the way we run the tutorial and we want the outputs to be consistent with how users will see them on the day. I patched packaging into CI so we can test that it executes.

@alecbcs alecbcs force-pushed the v1_packaging_updates branch from 22206c6 to b615a1c Compare August 6, 2025 06:03
alecbcs
alecbcs approved these changes Aug 6, 2025
View reviewed changes

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed checks. Looks good to me.

@alecbcs alecbcs merged commit c1f75b1 into main Aug 6, 2025
1 check passed
@alecbcs alecbcs deleted the v1_packaging_updates branch August 6, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecbcs alecbcs alecbcs approved these changes

Assignees

@alecbcs alecbcs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tldahlgren @alecbcs